Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[16.0] Collect-Info: put after post#5332

Merged
eriknordmark merged 2 commits into
lf-edge:16.0from
christoph-zededa:collect_info_PUT_16.0
Oct 29, 2025
Merged

[16.0] Collect-Info: put after post#5332
eriknordmark merged 2 commits into
lf-edge:16.0from
christoph-zededa:collect_info_PUT_16.0

Conversation

@christoph-zededa

@christoph-zededa christoph-zededa commented Oct 29, 2025

Copy link
Copy Markdown
Contributor

Description

Backport of #5302

PR dependencies

List all dependencies of this PR (when applicable, otherwise remove this
section).

How to test and validate this PR

Run make test

Changelog notes

collect-info does a upload with PUT in case POST fails

PR Backports

Checklist

  • I've provided a proper description
  • I've added the proper documentation
  • I've tested my PR on amd64 device
  • I've tested my PR on arm64 device
  • I've written the test verification instructions
  • I've set the proper labels to this PR

For backport PRs (remove it if it's not a backport):

  • I've added a reference link to the original PR
  • PR's title follows the template

And the last but not least:

  • I've checked the boxes above, or I've provided a good reason why I didn't
    check them.

Please, check the boxes above after submitting the PR in interactive mode.

some http servers do not allow to upload via POST
(f.e. webdav server), so if POST does not work, use PUT

originally POST was chosen as it is not idempotent

Signed-off-by: Christoph Ostarek <[email protected]>
(cherry picked from commit 5c192be)
added a test for the PUT failover in case the http server
does not allow to upload a file via POST

Signed-off-by: Christoph Ostarek <[email protected]>
(cherry picked from commit 5b8a33f)

@eriknordmark eriknordmark left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eriknordmark eriknordmark merged commit 406d39c into lf-edge:16.0 Oct 29, 2025
42 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants