[16.0] Fix log.Errorf usage#5447
Merged
Merged
Conversation
PR lf-edge#5414 fails building to do it picking up a new version of golang and hitting: cmd/volumemgr/handlevolumeref.go:260:15: non-constant format string in call to (*github.com/lf-edge/eve/pkg/pillar/base.LogObject).Errorf This fixes that particular issue (but there might be more non-constant strings like this to fix.) Signed-off-by: eriknordmark <[email protected]> (cherry picked from commit 42ec068)
9 tasks
rene
approved these changes
Nov 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport #5423
PR #5414 fails building to do it picking up a new version of golang and hitting: cmd/volumemgr/handlevolumeref.go:260:15: non-constant format string in call to (*github.com/lf-edge/eve/pkg/pillar/base.LogObject).Errorf This fixes that particular issue (but there might be more non-constant strings like this to fix.)
(cherry picked from commit 42ec068)
Changelog notes
None
Checklist
For backport PRs (remove it if it's not a backport):
And the last but not least:
check them.
Please, check the boxes above after submitting the PR in interactive mode.