[16.0] Fix flaky GoroutinesMonitor Go test#5469
Merged
rene merged 1 commit intoDec 1, 2025
Merged
Conversation
…ecrease The test was failing due to a race condition when checking the exact number of entries removed from the stats slice during dynamic resizing. The test expected exactly 720 entries to be removed when halving the slice size, but due to timing variations in the asynchronous monitor, the actual number could differ. The fix removes the exact count assertion and instead verifies that resizing occurred with the correct new size and that some entries were removed. This maintains test coverage while eliminating the flakiness. Signed-off-by: Nikolay Martyanov <[email protected]> (cherry picked from commit 4573c50)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport of #5467
PR dependencies
None.
How to test and validate this PR
No external manual test is required.
Changelog notes
No user-facing changes.
Checklist
check them.