[16.0] Non cancelable context#5501
Merged
eriknordmark merged 4 commits intoDec 18, 2025
Merged
Conversation
Update eve-libs to include context validation in dialer. Signed-off-by: Paul Gaiduk <[email protected]> (cherry picked from commit a840bb2) Signed-off-by: Paul Gaiduk <[email protected]>
Validate that the context passed to SendOnIntf is not nil and is cancelable. Otherwise, dump the stack for better traceability. Signed-off-by: Paul Gaiduk <[email protected]> (cherry picked from commit 96f45c4)
Replace context.Background with context from GetContextForAllIntfFunctions - it's cancelable and thus more suitable for network operations. Signed-off-by: Paul Gaiduk <[email protected]> (cherry picked from commit 77ec87b)
When doing HTTP requests in loops it's a good practice to close the response body explicitly after reading it, instead of deferring it until the surrounding function returns. This helps to free up resources sooner and avoid potential resource leaks, especially in bigger loops. Signed-off-by: Paul Gaiduk <[email protected]> (cherry picked from commit 4d88c7a)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 16.0 #5501 +/- ##
==========================================
+ Coverage 19.52% 28.08% +8.55%
==========================================
Files 19 19
Lines 3021 2314 -707
==========================================
+ Hits 590 650 +60
+ Misses 2310 1520 -790
- Partials 121 144 +23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
milan-zededa
approved these changes
Dec 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport of #5497
PR dependencies
None.
How to test and validate this PR
This PR should not change EVE's behavior, just make it more robust. So existing testing should suffice.
Changelog notes
Improve context management in controllerconn.
Checklist