[16.0] spec.sh json output fix for pkg/debug build#5509
Merged
Conversation
pkg/debug build blocked by spec.sh json output - Move COMMA variable out of output - skip non-link files in /sys/class/net. This may be only an issue when building pkg/debug on MacOS aarch64 building for ZARCH=amd64 due to the Docker desktop shim linux kernel. - "docker build -f Dockerfile.spec ." to quickly test spec.sh Signed-off-by: Andrew Durbin <[email protected]> (cherry picked from commit 780f0c0)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 16.0 #5509 +/- ##
==========================================
+ Coverage 19.52% 28.08% +8.55%
==========================================
Files 19 19
Lines 3021 2314 -707
==========================================
+ Hits 590 650 +60
+ Misses 2310 1520 -790
- Partials 121 144 +23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport of #5506 , from @andrewd-zededa
How to test and validate this PR
Changelog notes
Fix spec.sh script to not list bonding network interfaces
Checklist
check them.