Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[16.0] fix spec.sh usb#5528

Merged
eriknordmark merged 2 commits into
lf-edge:16.0from
christoph-zededa:16.0_fix_spec.sh_usb
Jan 5, 2026
Merged

[16.0] fix spec.sh usb#5528
eriknordmark merged 2 commits into
lf-edge:16.0from
christoph-zededa:16.0_fix_spec.sh_usb

Conversation

@christoph-zededa

@christoph-zededa christoph-zededa commented Jan 5, 2026

Copy link
Copy Markdown
Contributor

Description

Backport of #5520, #5523

How to test and validate this PR

  • Run spec.sh -u | jq . on a machine with a USB controller (on PCI bus) and a USB device.
  • Check that spec.sh is the same in the debug container and in the installer container.

Changelog notes

  • Fix spec.sh for USB devices.
  • Make spec.sh same in installer and debug package.

Checklist

  • I've provided a proper description
  • I've added the proper documentation
  • I've tested my PR on amd64 device
  • I've tested my PR on arm64 device
  • I've written the test verification instructions
  • I've set the proper labels to this PR

And the last but not least:

  • I've checked the boxes above, or I've provided a good reason why I didn't
    check them.

Please, check the boxes above after submitting the PR in interactive mode.

`print_usb_devices` now uses the `$COMMA` mechanism to add a
comma after every device

Signed-off-by: Christoph Ostarek <[email protected]>
(cherry picked from commit 56f906f)
@christoph-zededa christoph-zededa changed the base branch from master to 16.0 January 5, 2026 15:23
@christoph-zededa christoph-zededa changed the title 16.0 fix spec.sh usb [16.0] fix spec.sh usb Jan 5, 2026
@christoph-zededa christoph-zededa marked this pull request as ready for review January 5, 2026 16:38
@christoph-zededa

Copy link
Copy Markdown
Contributor Author

/rerun red

this is necessary for spec.sh to also get updated in the
installer package after previous commit

Signed-off-by: Christoph Ostarek <[email protected]>
(cherry picked from commit b363101)

@eriknordmark eriknordmark left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eriknordmark eriknordmark merged commit 9ae36ff into lf-edge:16.0 Jan 5, 2026
32 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants