Throw error from DockItem#activate only for non-destroyed dock item

kuychaco · BinaryMuse · commit d22a410887e4 · 2017-09-07T17:19:57.000-07:00
diff --git a/lib/views/dock-item.js b/lib/views/dock-item.js
@@ -126,8 +126,8 @@ export default class DockItem extends React.Component {
         if (dock && dock.show) {
           dock.show();
         }
-      } else {
-        throw new Error('Cannot find pane for item in `DockItem#activate`');
+      } else if (this.dockItem && !this.didCloseItem) {
+        throw new Error('Could not find pane for a non-destroyed DockItem');
       }
     });
   }

Original file line number	Diff line number	Diff line change
`@@ -126,8 +126,8 @@ export default class DockItem extends React.Component {`
`126`	`126`	`if (dock && dock.show) {`
`127`	`127`	`dock.show();`
`128`	`128`	`}`
`129`		`- } else {`
`130`		- throw new Error('Cannot find pane for item in `DockItem#activate`');
	`129`	`+ } else if (this.dockItem && !this.didCloseItem) {`
	`130`	`+ throw new Error('Could not find pane for a non-destroyed DockItem');`
`131`	`131`	`}`
`132`	`132`	`});`
`133`	`133`	`}`