A couple small changes for subvectors #3896
Conversation
5d9d8d8 to
89d70d3
Compare
|
Job Coverage on eaa757f wanted to post the following: CoverageInconsistent report tags were found between the head and base reports. Inconsistent tags: This comment will be updated on new commits. |
This ensures the move constructor is invoked and the caller releases ownership per https://stackoverflow.com/a/71930927
|
If you're ok with the API changes @roystgnr, this would be a PR that I'd like included in a libmesh update since I have multiple in-flight MOOSE PRs waiting on the libmesh update for other reasons that use these APIs |
|
So if we were to put an update in without this and then the MOOSE PRs got merged, this could no longer pass CI |
|
well ironically this is failing all the MOOSE targets, but for unrelated reasons |
|
If we can get this in ASAP then we should definitely update the current submodule update PR. I'm chomping at the bit to get multiple features into MOOSE, though; if those failures are unrelated then let's merge anyway and if they're related then let me know if there's anything I can do to help fix them. |
|
Job Test MOOSE on eaa757f : invalidated by @lindsayad |
|
Job Test MOOSE mac on eaa757f : invalidated by @lindsayad |
|
I'm 99% sure they are unrelated but let's ensure the remaining 1% |
|
Job Test MOOSE ARM mac on eaa757f : invalidated by @lindsayad |
unique_ptrby value when restoring instead of an rvalue of the object. I think this makes thegetandrestoreAPIs pair better. I know that this is changing a publicly available API but as @roystgnr pointed out in Static condensation #3883 it's only been around for a couple months so I'm 🤞 that he and @jwpeterson will allow it. If not, nbd, I'll go through the deprecation process