Create Elem::is_internal API for local node indices
#3897
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Job Coverage on 9d64dd4 wanted to post the following: Coverage
Warnings
This comment will be updated on new commits. |
||||||||||||||||||||||||||
jwpeterson
reviewed
Jul 2, 2024
src/geom/elem.C
Outdated
| return false; | ||
|
|
||
| case 1: | ||
| return !is_vertex(i); |
There was a problem hiding this comment.
Since you use this->dim, I'd also use this->is_vertex, this->is_edge, etc. for consistency. I generally prefer using this->, since it makes it clear to anyone reading the code for the first time that you're calling a member function.
|
Job Test 32bit on 3153020 : invalidated by @lindsayad |
|
Job Test clang on 3153020 : invalidated by @lindsayad |
|
Job Test with threads on 3153020 : invalidated by @lindsayad |
roystgnr
reviewed
Jul 10, 2024
| @@ -127,7 +127,7 @@ class InfHex : public InfCell | |||
| /** | |||
| * We number faces last. | |||
| */ | |||
| virtual bool is_face(const unsigned int i) const override final { return (i >= 12 && i < 16); } | |||
| virtual bool is_face(const unsigned int i) const override final { return (i >= 12 && i < 17); } | |||
There was a problem hiding this comment.
Damn, can't believe this has been sitting around for so long. Thank you!
roystgnr
reviewed
Jul 10, 2024
| @@ -128,7 +128,7 @@ bool Tri7::is_vertex(const unsigned int i) const | |||
|
|
|||
| bool Tri7::is_edge(const unsigned int i) const | |||
| { | |||
| if (i < 3) | |||
| if (i < 3 || i == 6) | |||
roystgnr
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful for determining condensed/uncondensed dofs for uses cases such as static condensation in #3883