-
-
Notifications
You must be signed in to change notification settings - Fork 17
Thread-scoped control flow and events #171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
io-no
wants to merge
50
commits into
dev
Choose a base branch
from
single-thread-control-flow
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and process-scoped
Frank01001
reviewed
Nov 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as what is implemented up to this point, it seems ok.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first PR that attempts to shift some functionalities of libdebug from a process-scoped to a thread-scoped basis.
I encourage a logical code review, even if it is a draft, to confirm the direction and APIs. I tried to adhere to what we decided together weeks ago, but I had to make some additional decisions.
All the limitations listed below are documented precisely in the code with some TODOs and, where necessary, with warnings for the users.
Why a draft?
What this PR includes
continue
,finish
,next
,step
,step_until
,wait
) are now process-scoped when called on theDebugger
object and thread-scoped when called on aThreadContext
.InternalThreadContext
to hide and manage part of the new complexity introduced. It will be better employed when I address the limitations mentioned above.What about limitations?
next
andfinish
are still blocking. I have not changed them to better isolate some race conditions introduced by the new features.ensure_process_stopped
for a thread to allow access to thread-safe resources when a single thread is stopped but others are running. This is also useful for the first point.running
,scheduled
, ... flags can be better managed, as can the status flags of the debugger.Why did I not solve these limitations?
Because they are part of other changes that we want to apply to libdebug, which we have not yet implemented. I wanted to avoid adding layers of poor code to circumvent the problems. Also, it is already quite a large PR.