Thanks, this seems like a good idea!

Thanks!

The deploy.sh is necessary to pack up everything in an actual working macOS app; otherwise, it's looking for libraries that may or not be installed on the target system.

Yep, this totally makes sense. Sadly I don't have a machine with OSX on it, so I don't think I'll be able to iterate on it here. I think it's probably best to merge this even though all of the artifacts aren't built properly so that at least we get cross-platform build validation.

I'm in the same boat as @omgitsraven when it comes to Linux distributions (in terms of not knowing much). It seems like folks prefer to have it built from source in a package manager, though Snaps are attempting to be a common package format (maybe?). I don't know if it's worth trying to deploy on Linux, vs just building + testing.

Agreed. Right now the artifacts are still zipped up (this might be useful to help debugging this workflow file), but I don't expect that they'll be particularly useful to linux end-users.

It would make the history cleaner if the commits were squashed (with a meaningful commit message), and it looks like this PR also accidentally adds a few binary files. You can use git filter-branch to remove those files from the commits, so they don't take up space in repo history.

When you click the down-arrow on the "merge pull-request" button, there's an option to squash commits, which uses the pull-request text as the commit message. This would be a lot easier for me (I'd rather not learn how to rewrite history in Git), so if it's cool with you, we could work on making my pull-request text a good commit message, and work from there.

Oh, also, I managed to get windows actions building!

ping @mkeeter

Hi – I'm relatively overloaded right now, so no promises when I'll look at this!

What's the purpose of changing the CMake version detection? On master, the new command (git describe --dirty="+" --tags --always) gives a relatively nonsensical name based on an old branch:

➜  libfive git:(master) git describe --dirty="+" --tags --always
rip-dmc-1685-ge1da2fb6

@mkeeter no worries! I just wanted to make sure that you saw it.

What's the purpose of changing the CMake version detection

I couldn't get "bash -c" to run on windows without installing WSL, which doesn't appear to be possible on the machines that github uses to run this code. Shame about the issue though... Looks like the only use for the "bash -c" is so that you can use || echo '+', do you know if this possible to do in CMake without using bash?