-
Notifications
You must be signed in to change notification settings - Fork 22
Quality of life tweaks #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@tiennou Lovely with some quality of life improvements. Both of the first outlined issues, I've also encountered when taking docurium out for a spin.
Any chance of having this reviewed and potentially merged? |
Sorry, I've kept piling on for a few years 😉(the commit list above is unordered though). Highlights are :
|
1cd8be3
to
9d88c29
Compare
Rebased, I've restored the test suite as well, so tests are "green" all along (thanks @carlosmn Care to review sometime soon ? I'd really like the documentation cleanups in libgit2/libgit2#4530 to be upstreamed, and it's been open for a while now… |
0ef5bca
to
6d3cb17
Compare
89733d0
to
e9fbd67
Compare
Due to the `if` we'd return `nil` if the message was not an array.
It seems Clang can arbitrarily raise errors (transient NULL-byte reads from files that exist). Handle those errors by retrying the parsing step 3 times, just in case it goes away.
This is a collection of fixes + features I got while learning how it works.
9f038b0 is the main one. It fixes the rendering mess of bulleted structs comments.
b3a09b3 adds a
cm doc --for=$version
option so you're not forced to build all versions each time (which is nice 😉).22b9c5c is a style change that makes struct members render like function parameters descriptions. It can be dropped. I was just looking at how the HTML worked.