Allow NULL refspec in git_remote_push

yuyichao · yuyichao · commit 90cdf44ffb7c · 2017-04-29T13:00:07.000-04:00
Since this is allowed in `git_remote_upload`
diff --git a/src/remote.c b/src/remote.c
@@ -2412,7 +2412,7 @@ int git_remote_push(git_remote *remote, const git_strarray *refspecs, const git_
 		proxy = &opts->proxy_opts;
 	}
 
-	assert(remote && refspecs);
+	assert(remote);
 
 	if ((error = git_remote_connect(remote, GIT_DIRECTION_PUSH, cbs, proxy, custom_headers)) < 0)
 		return error;

Original file line number	Diff line number	Diff line change
`@@ -2412,7 +2412,7 @@ int git_remote_push(git_remote remote, const git_strarray refspecs, const git_`
`2412`	`2412`	`proxy = &opts->proxy_opts;`
`2413`	`2413`	`}`
`2414`	`2414`
`2415`		`- assert(remote && refspecs);`
	`2415`	`+ assert(remote);`
`2416`	`2416`
`2417`	`2417`	`if ((error = git_remote_connect(remote, GIT_DIRECTION_PUSH, cbs, proxy, custom_headers)) < 0)`
`2418`	`2418`	`return error;`