Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Duplicate base names kills build on older versions of Visual Studio #3356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
johnhaley81 opened this issue Aug 5, 2015 · 5 comments · Fixed by #3360
Closed

Duplicate base names kills build on older versions of Visual Studio #3356

johnhaley81 opened this issue Aug 5, 2015 · 5 comments · Fixed by #3360

Comments

@johnhaley81
Copy link
Contributor

So Visual Studio 2008 and before will ignore the base-names of files. We've seen this before in #330. This is something you guys might not really want to worry about since it is an older version of VS but it does however break toolchains like GYP.

The files in question are:
@ethomson
Copy link
Member

ethomson commented Aug 5, 2015

Yes, this needs to be fixed. Can you send a PR?

johnhaley81 pushed a commit to nodegit/libgit2 that referenced this issue Aug 5, 2015
Fix duplicate basenames to support older VS
42e8ade 
With Visual Studio versions 2008 and older they ignore the full path to files and only check
the basename of the file to find a collision. Additionally, having duplicate basenames can break
other build tools like GYP.

This fixes libgit2#3356
@johnhaley81
Copy link
Contributor Author

👍

I was fixing this on maint/v0.23. Do you want it on master?

@ethomson
Copy link
Member

ethomson commented Aug 5, 2015

You're awesome. Both would be amazing. ✨

@johnhaley81
Copy link
Contributor Author

Cool! You'll have them later today. :D

johnhaley81 pushed a commit to nodegit/libgit2 that referenced this issue Aug 5, 2015
Fix duplicate basenames to support older VS
7dab451 
With Visual Studio versions 2008 and older they ignore the full path to files and only check
the basename of the file to find a collision. Additionally, having duplicate basenames can break
other build tools like GYP.

This fixes libgit2#3356
johnhaley81 pushed a commit to nodegit/libgit2 that referenced this issue Aug 5, 2015
Fix duplicate basenames to support older VS
1e3596d 
With Visual Studio versions 2008 and older they ignore the full path to files and only check
the basename of the file to find a collision. Additionally, having duplicate basenames can break
other build tools like GYP.

This fixes libgit2#3356
johnhaley81 pushed a commit to nodegit/libgit2 that referenced this issue Aug 5, 2015
Fix duplicate basenames to support older VS
2cb4b65 
With Visual Studio versions 2008 and older they ignore the full path to files and only check
the basename of the file to find a collision. Additionally, having duplicate basenames can break
other build tools like GYP.

This fixes libgit2#3356
@johnhaley81 johnhaley81 mentioned this issue Aug 5, 2015
Merged
johnhaley81 pushed a commit to nodegit/libgit2 that referenced this issue Aug 5, 2015
Fix duplicate basenames to support older VS
eba784d 
With Visual Studio versions 2008 and older they ignore the full path to files and only check
the basename of the file to find a collision. Additionally, having duplicate basenames can break
other build tools like GYP.

This fixes libgit2#3356
@johnhaley81 johnhaley81 mentioned this issue Aug 5, 2015
Merged
@johnhaley81
Copy link
Contributor Author

Thanks @ethomson!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix duplicate basenames to support older VS on master nodegit/libgit2
2 participants
@johnhaley81 @ethomson