Update contributing and conventions #1386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The discussion about converting some of our foreach-style APIs to use iterator objects got me wanting to make a list of good starter projects. I put it in CONTRIBUTING.md and then went crazy with updates to that file and to CONVENTIONS.md.
When the examples/diff.c was written, there was not yet a revparse API. Now we can use it to make command line parsing way better with less code. Yay!
|
@arrbee, may I kindly ask you whether you're serious about this C89-compilance statement? Did you ever try a |
|
@scunz: We're very serious. It's not C89, pure, but it's the version of C89 that builds in MSVC. If it doesn't build there, we cannot merge it. And that's the version of the standard that MSVC supports. |
|
C89 refers to whatever MSVC will let us get way with. |
|
Looking good @arrbee. <3 |
vmg
pushed a commit
that referenced
this pull request
Mar 2, 2013
Update contributing and conventions
|
I can understand the MSVC requirement. However, then we should write it like that: Ansi-C89 with either MSVC or GNU-Extensions. The whole code base isn't compilable without the |
phatblat
pushed a commit
to phatblat/libgit2
that referenced
this pull request
Sep 13, 2014
Update contributing and conventions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The discussion on #1384 made me want to write a "starter projects" list, so I put that into CONTRIBUTING.md and then went a little crazy updating that file and the CONVENTIONS.md file as well. I'm not sure if you'll agree 100% with my proposed changes, but please take a look.
I also bundled in another commit with a simplification to the examples/diff.c code.