Fix broken build when MSVC SDL checks is enabled #1569
Conversation
| @@ -782,8 +782,12 @@ static bin_tree_t *create_token_tree (re_dfa_t *dfa, | |||
| #ifdef DEBUG | |||
| /* Note: length+1 will not overflow since it is checked in init_dfa. */ | |||
| dfa->re_str = re_malloc (char, length + 1); | |||
| #if _MSC_VER >= 1400 | |||
| strncpy_s (dfa->re_str, length + 1, pattern, length + 1); | |||
There was a problem hiding this comment.
SDL and DEBUG?
I don't understand the rationale here.
We made a pass to make sure SDL passed (though we did not apply banned.h because, of course, some people run SDL on the binaries they ship. But it doesn't make sense to me to make the DEBUG version SDL compliant. Are you shipping debug DLLs? Are you running SDL on as part of your CI build (and building debug DLLs)?
There was a problem hiding this comment.
I am not checking the binaries. I compile from source directly. I am not using CMake, but dragging all the .c into a .vcxproj to compile. SDL is turned on in that .vcxproj
There was a problem hiding this comment.
My question is: you're using SDL on debug builds?
There was a problem hiding this comment.
Yes, SDL, debug build, win32
There was a problem hiding this comment.
I'm gonna pass on this change to regcomp, since it's in debug-only code. Can you drop it so I can merge the other fixes? Thanks!
There was a problem hiding this comment.
Changes to regcomp has been dropped.
|
Thank you! |
Fix broken build when MSVC SDL checks is enabled
|
BTW, where to make changes to regcomp.c? |
Fix broken build when MSVC SDL checks is enabled
Fix broken build when MSVC SDL checks is enabled
Mostly initialize local variables.