Unbreak git_remote_ls on a local transport after disconnecting. #1678
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -600,6 +600,8 @@ static void local_free(git_transport *transport) | |||
| { | |||
| transport_local *t = (transport_local *)transport; | |||
|
|
|||
| git_vector_free(&t->refs); | |||
There was a problem hiding this comment.
This wouldn't free the contents of the vector, so we're back to leaking. You need to have the same git_vector_foreach here that you have in local_connect.
|
@carlosmn Pushed a fix. |
|
Looks good. |
|
Thanks for adding a test! |
arrbee
added a commit
that referenced
this pull request
Jun 25, 2013
…disconnect Unbreak git_remote_ls on a local transport after disconnecting.
|
Yeah. Unfortunately, that issue is now part of the 0.19.0 release 😭 |
phatblat
pushed a commit
to phatblat/libgit2
that referenced
this pull request
Sep 13, 2014
…-after-disconnect Unbreak git_remote_ls on a local transport after disconnecting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue introduced in #1675, where
git_remote_lswould stop working on local transports after disconnecting.@carlosmn @arrbee Can you take a look?