Remote: Set an error when a remote cannot be found. #2389
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inside `git_remote_load`, the calls to `get_optional_config` use `giterr_clear` to unset any errors that are set due to missing config keys. If neither a fetch nor a push url config was found for a remote, we should set an error again.
vmg
pushed a commit
that referenced
this pull request
Jun 3, 2014
…o-remote-found Remote: Set an error when a remote cannot be found.
phatblat
pushed a commit
to phatblat/libgit2
that referenced
this pull request
Sep 13, 2014
…-when-no-remote-found Remote: Set an error when a remote cannot be found.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inside
git_remote_load, the calls toget_optional_configusegiterr_clearto unset any errors that are set due to missing configkeys. If neither a fetch nor a push url config was found for a remote,
we should set an error again.