netops: return GIT_ECERTIFICATE when it fails the basic tests #2680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we first ask OpenSSL to verify the certfiicate itself (rather than the HTTPS specifics), we should also return GIT_ECERTIFICATE. Otherwise, the caller would consider this as a failed operation rather than a failed validation and not call the user's own validation.
|
Nice. This seems correct enough to merge as-is without updating the unit tests to have a test that fails here. |
|
Though I'm curious if you're thinking of scripting OpenSSL or if you're going to drop some invalid cert into the test resources? |
ethomson
added a commit
that referenced
this pull request
Nov 3, 2014
netops: return GIT_ECERTIFICATE when it fails the basic tests
|
I was thinking of scripting some CA and cert-creation scripts. I suppose we could create them once and have them as fixtures, but then we'd probably just forget how to create them if we decide we have more edge cases, so I would really like it if we could copy-paste-modify when adding new tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we first ask OpenSSL to verify the certfiicate itself (rather
than the HTTPS specifics), we should also return
GIT_ECERTIFICATE. Otherwise, the caller would consider this as a failed
operation rather than a failed validation and not call the user's own
validation.
We really need to figure out the creation of a test CA and certs and http-hosting repos so we can automatically test this.