clone example: don't divide by zero #2815
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| int index_percent = (100*pd->fetch_progress.indexed_objects) / pd->fetch_progress.total_objects; | ||
| int network_percent, index_percent; | ||
|
|
||
| if (!pd->fetch_progress.total_objects || !pd->total_steps) |
There was a problem hiding this comment.
Isn't total_steps checked below?
Local transports don't have data about the size, avoid dividing by zero in the callback.
|
That looks way better. 👍 |
|
Thanks, @Therzok ! |
carlosmn
added a commit
that referenced
this pull request
Jan 12, 2015
clone example: don't divide by zero
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Local transports don't have data about the size, avoid dividing by
zero in the callback.
Fixes #2812