Check the repository version #3249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git will assume the repository format version is 0 if the value is not there. Do the same.
This is something we do on re-init but not when opening a repository. This hasn't particularly mattered up to now as the version has been 0 ever since the first release of git, but the times, they're a-changing and we will soon see version 1 in the wild. We need to make sure we don't open those.
| git_config_free(config); | ||
| if (config && | ||
| ((error = load_config_data(repo, config)) < 0 || | ||
| (error = load_workdir(repo, config, &parent))) < 0) |
There was a problem hiding this comment.
Misplaced parenthesis here: see #3251
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It hasn't mattered that we don't check for it on open, as it has been 0 since the first release of git, way back when; but times, they're a-changing and we will soon(ish) see version 1in the wild and we must take care that we don't open those and possibly break something (or just produce uncomprehensible results).