Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Rename FALLBACK to UNSPECIFIED #3255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 25, 2015
Merged

Rename FALLBACK to UNSPECIFIED #3255

merged 1 commit into from
Jun 25, 2015

Conversation

carlosmn
Copy link
Member

Fallback describes the mechanism, while unspecified explains what the
user is thinking.

@carlosmn
Rename FALLBACK to UNSPECIFIED
c2418f4 
Fallback describes the mechanism, while unspecified explains what the
user is thinking.
@ethomson
Copy link
Member

Dumb question: should the default value be DEFAULT and not UNSPECIFIED?

@arthurschreiber
Copy link
Member

👍 for DEFAULT.

@carlosmn
Copy link
Member Author

The default would indeed be named _DEFAULT but this is not what we're expressing here. What we're expressing is that we do not want to override the value at the level which is specified. It does not mean that we're going to use the default, as there may be a setting lower down.

@ethomson
Copy link
Member

Got it. Thanks for the clarification.

ethomson added a commit that referenced this pull request Jun 25, 2015
@ethomson
Merge pull request #3255 from libgit2/cmn/rename-unspecified
c0280bd 
Rename FALLBACK to UNSPECIFIED
@ethomson ethomson merged commit c0280bd into master Jun 25, 2015
@carlosmn carlosmn deleted the cmn/rename-unspecified branch June 26, 2015 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carlosmn @ethomson @arthurschreiber