Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix 8.3 filename tests failure when 8.3 is disabled #3280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 1, 2015
Merged

Fix 8.3 filename tests failure when 8.3 is disabled #3280

merged 1 commit into from
Jul 1, 2015

Conversation

linquize
Copy link
Contributor

@linquize linquize commented Jul 1, 2015

Fix 8.3 filename tests failure when 8.3 is disabled

@ethomson
Copy link
Member

ethomson commented Jul 1, 2015

I don't understand. Is there just a test failure? What test? Why?

We shouldn't include .git in the list of shortnames. That's already a prohibited name. If this is just working around a test failure then we should fix the test.

@linquize
Copy link
Contributor Author

linquize commented Jul 1, 2015

failed test were: test_repo_reservedname__includes_shortname_on_win32 and
test_repo_reservedname__includes_shortname_when_requested

cl_assert_equal_i(2, reserved_len);
but reserved_len was 3
because when 8.3 is off, it added ".git" to the end of the list (repeated), so reserved_len was 3

@ethomson
Copy link
Member

ethomson commented Jul 1, 2015

I see. Out of curiosity, what system / filesystem is that?

ethomson added a commit that referenced this pull request Jul 1, 2015
@ethomson
Merge pull request #3280 from linquize/8.3
bf7d276 
Fix 8.3 filename tests failure when 8.3 is disabled
@ethomson ethomson merged commit bf7d276 into libgit2:master Jul 1, 2015
@linquize
Copy link
Contributor Author

linquize commented Jul 1, 2015

win 8 x64, NTFS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@linquize @ethomson