Renamed /src/win32/buffer.c to /src/win32/buffer_win32.c #3357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you rebase this PR and force push? |
Our path functions expect to work with slashes, so convert a path with backslashes into one with slashes at the top of the function.
Extract the backslash-to-slash conversion into a helper function.
This prevents issues with compiling using MSVC caused by multiple object files with the same name.
9a9178b to
0a6ae04
Compare
|
Looks like great minds think alike! #3360 also addressed this issue. Since that one was cleanly based on master and was not re-adding prior commits, I went ahead and merged that one, but thank you! Looking forward to future PRs. |
|
No worries! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents issues with compiling using MSVC caused by multiple object
files with the same name.