stream: allow registering a user-provided TLS constructor #3465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
12ae5c1 to
50b6261
Compare
|
Will this make it into 0.24.0? |
| @@ -39,6 +39,19 @@ typedef struct git_stream { | |||
| void (*free)(struct git_stream *); | |||
| } git_stream; | |||
|
|
|||
| typedef int (*git_stream_ctor)(git_stream **out, const char *host, const char *port); | |||
There was a problem hiding this comment.
I think that this might slightly better match some of the existing type names if it were git_stream_cb. (See for example git_transport_cb which has a similar purpose.)
|
Minor nit on the name, otherwise 👍 |
98fc0a8 to
5acca4b
Compare
This allows the application to use their own TLS stream, regardless of the capabilities of libgit2 itself.
5acca4b to
7fafde6
Compare
ethomson
added a commit
that referenced
this pull request
Nov 4, 2015
stream: allow registering a user-provided TLS constructor
|
Lovely, thanks! |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the application to use their own TLS stream, regardless of
the capabilities of libgit2 itself.
The naming feels a bit all over the place, so suggestions there would be great.