signature: Strip crud #3478
Merged
signature: Strip crud #3478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also included two commits to fix warnings. :o |
|
Makes sense, I guess. If this is considered canonical normalisation, I guess we should do it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, Git does this: https://github.com/github/git/blob/github/ident.c#L137-L155
And we don't. So I feel we should be doing this. As to do the same thing that Git does. Even though whatever Git does is weird. But this is causing commits to differ from my experiments. So it would make my life easier if we did the same thing that Git does.
cc @carlosmn @ethomson