Handle submodules with paths in git_submodule_update
#3500
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 4, 2015 16:53
Test that `git_submodule_update` can handle a submodule that is freshly cloned and has a path differing from its name.
Reload the HEAD and index data for a submodule after reading the configuration. The configuration may specify a `path`, so we must update HEAD and index data with that path in mind.
bfa4593 to
f4b0267
Compare
carlosmn
added a commit
that referenced
this pull request
Nov 8, 2015
Handle submodules with paths in `git_submodule_update`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
git_submodule_reload, we should read the configuration values for a submodule before updating the HEAD and index data. The configuration values may specify a path for the submodule (that is not the same as its name), and that path should be used to lookup HEAD and index data.FWIW, we noticed this when trying to
git_submodule_updatesubmodules in a freshly-cloned https://github.com/boostorg/boost repository, where the submodule paths were not the same as the submodule names.