Add a new build flag to disable the pool allocator #3577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ool_malloc calls straight to git__malloc
src/pool.h
Outdated
|
|
||
| #ifdef GIT_DEBUG_POOL | ||
| #include "vector.h" | ||
| #endif |
Member
|
Thanks, this looks pretty straightforward. Other than the ifdef'd include, I think we could include this. |
Contributor
Author
|
awesome, I just pushed a second commit which removes the ifdef. |
src/pool.h
Outdated
| /* | ||
| * Misc utilities | ||
| */ | ||
| #ifndef _DEBUG_POOL |
Member
There was a problem hiding this comment.
Should this be GIT_DEBUG_POOL?
Contributor
Author
There was a problem hiding this comment.
yep, looks like I typo'd that.
Member
|
Thanks for tackling this! |
ethomson
pushed a commit
that referenced
this pull request
Feb 28, 2016
Add a new build flag to disable the pool allocator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calls to git_pool__malloc are proxied directly to git__malloc. Allocations are tracked using a git_vector and freed when git_pool_clear is called. I am currently using ifdef/ifndef to enable and disable the debug code. I also enable/disable a couple of the pool test cases which won't work when debug is turned on.