USE_NSECS fixes #3638
Merged
USE_NSECS fixes #3638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 25, 2016 11:40
The index::nsec::staging_maintains_other_nanos test was created to ensure that when we stage an entry when GIT_USE_NSECS is *unset* that we truncate the index entry and do not persist the (old, invalid) nanosec values. Ensure that when GIT_USE_NSECS is *set* that we do not do that, and actually write the correct nanosecond values.
Android NDK does not have a `struct timespec` in its `struct stat` for nanosecond support, instead it has a single nanosecond member inside the struct stat itself. We will use that and use a macro to expand to the `st_mtim` / `st_mtimespec` definition on other systems (much like the existing `st_mtime` backcompat definition).
|
Fixes #3635 |
|
(Note that #3635 failed when |
|
This is beautiful in a train-crash kind of way 👍 |
That's not the first time that's been said about me. |
tomas
added a commit
to tomas/libgit2
that referenced
this pull request
Jan 31, 2018
This should have been part of PR libgit2#3638. Without this we still get nsec-related errors, even when using -DGIT_USE_NSEC: error: ‘struct stat’ has no member named ‘st_mtime_nsec’
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include some nanosecond handling fixes for Android NDK's
struct stat, which uses neitherst_mtimnorst_mtimespecto contain astruct timespec, and instead simply lays down anst_mtime_nsecfield next tost_mtime.Move us over to using that by default, and then setting:
for compatibility with saner platforms. This is akin to the backcompat behavior with
st_mtimeand so should seem relatively normal everywhere.Also, fix a unit test that assumed that it would not be run in a
USE_NSECS=ONenvironment: it validated that when writing a new index entry that the nanoseconds would be truncated and thus0. (It was meant to ensure that we did not propagate old nanosecond entries that git.git wrote. We should, of course, validate that we write our own values when we're running with nanoseconds enabled.)