commit: split creating the commit and writing it out #3652
Conversation
261f86a to
f5feb24
Compare
|
Hm. So, I must admit that it seems odd to me that I would personally rather see the |
|
I wasn't quite sure what to do about that. I went with keeping the solution we have which does not perform extra allocations. But come to think about it, when we split this off, the parent check doesn't mean much, as that's a check that should happen at the writing side. |
Sometimes you want to create a commit but not write it out to the objectdb immediately. For these cases, provide a new function to retrieve the buffer instead of having to go through the db.
f5feb24 to
47cb42d
Compare
|
I've updated the function to accept just the data, and we perform the validation at a higher level. |
commit: split creating the commit and writing it out
Sometimes you want to create a commit but not write it out to the
objectdb immediately. For these cases, provide a new function to
retrieve the buffer instead of having to go through the db.
This is new, so we should wait to merge until after the release.