Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Use AppVeyor's Start-FileDownload cmdlet #3799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 26, 2016
Merged

Use AppVeyor's Start-FileDownload cmdlet #3799

merged 1 commit into from
May 26, 2016

Conversation

sschuberth
Copy link
Contributor

Start-FileDownload maintains current directory context and allows
specifying a request timeout, see [1].

[1] https://www.appveyor.com/docs/how-to/download-file#start-filedownload-cmdlet

@sschuberth
Use AppVeyor's Start-FileDownload cmdlet
247665e 
Start-FileDownload maintains current directory context and allows
specifying a request timeout, see [1].

[1] https://www.appveyor.com/docs/how-to/download-file#start-filedownload-cmdlet
@ethomson
Copy link
Member

Sorry... I guess I'm not clear on the advantage. This seems reasonable, but do we need to maintain the directory context, or are we interested in the timeout?

@sschuberth
Copy link
Contributor Author

There's nothing to be sorry about. You're right that in this particular case there's not (yet) any advantage of using Start-FileDownload instead of Invoke-WebRequest. To be honest, I did this commit as part of a bulk change across different GitHub projects I've forked. For some of the other projects this change makes more sense as they benefit e.g. from specifying a timeout. I still submitted the change for libgit2 as Start-FileDownload now feels like the standard way downloads should be done in AppVeyor. But if you don't agree or would like to keep things simpler / more vanilla PowerShell-ish, I'm completely fine with closing this unmerged.

@ethomson
Copy link
Member

Okay! Thanks for clarifying, I just didn't see the immediate benefit so I was wondering if there was some detail that I did not understand.

If this is both recommended by AppVeyor and has benefits that we can use in the future, then I'll merge this. Thanks!

@ethomson ethomson merged commit 784bb30 into libgit2:master May 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sschuberth @ethomson