-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Documentation fixes #3980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation fixes #3980
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice findings. Looks all good besides the missing @defgroup
argument.
/** | ||
* @file git2/transaction.h | ||
* @brief Git transaction routines. | ||
* @defgroup Git transaction routines. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be @defgroup git_transaction Git transaction routines
instead. Please also remove the trailing dots from @brief
and @defgroup
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't actually use these blocks for anything with our current documentation generator, so it should just go away.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was trying to make docurium document those functions. Wasn't sure if the group being defined was a prerequisite, but I'll take them out then.
Oh, one more thing. Could you maybe clarify the commit messages a bit by prefixing them with the module they're touching primaily, please? E.g. "remote: fix indentation". Thanks for your work 👍 |
/** | ||
* @file git2/transaction.h | ||
* @brief Git transaction routines. | ||
* @defgroup Git transaction routines. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't actually use these blocks for anything with our current documentation generator, so it should just go away.
@@ -105,6 +105,9 @@ typedef struct { | |||
|
|||
GIT_EXTERN(int) git_describe_init_format_options(git_describe_format_options *opts, unsigned int version); | |||
|
|||
/** | |||
* An opaque struct that stores the result of a describe operation. | |||
*/ | |||
typedef struct git_describe_result git_describe_result; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The opaqueness is not something we need to specify in the text.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will fix.
Patch series redone from scratch.
|
Note: 8149b17 removes git_remote_rename_problem_cb. Not sure when it stopped being used though.