Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Documentation fixes #3980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 20, 2016
Merged

Documentation fixes #3980

merged 4 commits into from
Dec 20, 2016

Conversation

tiennou
Copy link
Contributor

@tiennou tiennou commented Nov 1, 2016

Note: 8149b17 removes git_remote_rename_problem_cb. Not sure when it stopped being used though.

Copy link
Member

@pks-t pks-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice findings. Looks all good besides the missing @defgroup argument.

/**
* @file git2/transaction.h
* @brief Git transaction routines.
* @defgroup Git transaction routines.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be @defgroup git_transaction Git transaction routines instead. Please also remove the trailing dots from @brief and @defgroup.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't actually use these blocks for anything with our current documentation generator, so it should just go away.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was trying to make docurium document those functions. Wasn't sure if the group being defined was a prerequisite, but I'll take them out then.

@pks-t
Copy link
Member

pks-t commented Nov 1, 2016

Oh, one more thing. Could you maybe clarify the commit messages a bit by prefixing them with the module they're touching primaily, please? E.g. "remote: fix indentation".

Thanks for your work 👍

/**
* @file git2/transaction.h
* @brief Git transaction routines.
* @defgroup Git transaction routines.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't actually use these blocks for anything with our current documentation generator, so it should just go away.

@@ -105,6 +105,9 @@ typedef struct {

GIT_EXTERN(int) git_describe_init_format_options(git_describe_format_options *opts, unsigned int version);

/**
* An opaque struct that stores the result of a describe operation.
*/
typedef struct git_describe_result git_describe_result;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The opaqueness is not something we need to specify in the text.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will fix.

@tiennou
Copy link
Contributor Author

tiennou commented Nov 1, 2016

Patch series redone from scratch.

docurium is giving me a hard time tough, as some things are left out of the parsing (eg. the whole of transaction.h, and things like git_branch_remote_name don't appear in the docs). Using the debug-heavy version I have here, it seems that clang sometimes misinterprets comments in some cases (eg, I get lots of :comment_null).

@carlosmn carlosmn merged commit 75db289 into libgit2:master Dec 20, 2016
@tiennou tiennou deleted the doc-fixes branch June 24, 2018 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants