Fix BIO_* functions method linking when compiled with libressl (OpenBSD). #4043
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've observed the same behaviour in the perl bindings: http://www.cpantesters.org/cpan/report/dd6ea9f8-c7bb-11e6-8b9c-8683a7a0ff84 |
|
Can we get this merged? |
|
I don't use libressl, but if @jacquesg says it's working for him then 👍 . Thanks @fudanchii ! 😀 |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I tried to build libgit2 in OpenBSD (as dependencies of rust's cargo) and found that it can't find BIO_* functions defined in openssl_stream.h. Obviously because it was guarded with openssl version check. I found a reference (below) that we can use libressl as we check openssl for version < 1.1.0. This patch does just that.
Thanks.
ref:
https://github.com/gentoo/libressl/blob/672ac74ce7b7cb2e4799b2d66bc0b1b1efa3454e/media-video/ffmpeg/files/ffmpeg-3.2-libressl.patch