Thanks to visit codestin.com
Credit goes to github.com

Skip to content

mbedTLS support #4173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Apr 22, 2018
Merged

mbedTLS support #4173

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
ca3b223
mbedtls: initial support
tiennou Mar 29, 2018
1a1875f
mbedtls: proper certificate verification
tiennou Mar 29, 2018
6c6be3c
mbedtls: use libmbedcrypto for hashing
tiennou Mar 29, 2018
60e1ad9
mbedtls: add global initialization
tiennou Mar 29, 2018
2419ccc
mbedtls: default cipher list support
tiennou Mar 29, 2018
ec79b0f
mbedtls: fix libgit2 hanging due to incomplete writes
tiennou Mar 29, 2018
262dfcf
mbedtls: enable Travis CI tests
tiennou Mar 29, 2018
4165bb7
mbedtls: use our own certificate validation
tiennou Mar 29, 2018
1edde0b
mbedtls: use mbedTLS certificate verification
tiennou Mar 29, 2018
382ed1e
mbedtls: load default CA certificates
tiennou Mar 29, 2018
b3e0280
mbedtls: display error codes as hex for consistency with mbedTLS docs
tiennou Mar 29, 2018
e3d764a
tests: clarify comment
tiennou Mar 29, 2018
5455475
cmake: make our preferred backend ordering consistent
tiennou Mar 29, 2018
10aff3d
travis: just grab what we need from mbedtls
tiennou Mar 29, 2018
cb2da47
travis: pass -fPIC when configuring mbedtls
tiennou Mar 29, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
mbedtls: display error codes as hex for consistency with mbedTLS docs 
Remaining parts of https://github.com/JuliaLang/julia/blob/8d47a314537779c8fb86642c54925613628a91b0/deps/patches/libgit2-mbedtls-fixup.patch
  • Loading branch information
@tiennou
tiennou committed Apr 11, 2018
commit b3e0280d0b76891cae9f9abb8650938f86b6ef2c
8 changes: 4 additions & 4 deletions src/streams/mbedtls.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,12 +181,12 @@ static int ssl_set_error(mbedtls_ssl_context *ssl, int error)
break;

case MBEDTLS_ERR_X509_CERT_VERIFY_FAILED:
giterr_set(GITERR_SSL, "SSL error: %x[%x] - %s", error, ssl->session_negotiate->verify_result, errbuf);
giterr_set(GITERR_SSL, "SSL error: %#04x [%x] - %s", error, ssl->session_negotiate->verify_result, errbuf);
ret = GIT_ECERTIFICATE;
break;

default:
giterr_set(GITERR_SSL, "SSL error: %x - %s", error, errbuf);
giterr_set(GITERR_SSL, "SSL error: %#04x - %s", error, errbuf);
}

return ret;
Expand All @@ -212,7 +212,7 @@ static int verify_server_cert(mbedtls_ssl_context *ssl)
char vrfy_buf[512];
int len = mbedtls_x509_crt_verify_info(vrfy_buf, sizeof(vrfy_buf), "", ret);
if (len >= 1) vrfy_buf[len - 1] = '\0'; /* Remove trailing \n */
giterr_set(GITERR_SSL, "the SSL certificate is invalid: %x - %s", ret, vrfy_buf);
giterr_set(GITERR_SSL, "the SSL certificate is invalid: %#04x - %s", ret, vrfy_buf);
return GIT_ECERTIFICATE;
}

Expand Down Expand Up @@ -410,7 +410,7 @@ int git_mbedtls__set_cert_location(const char *path, int is_dir)
mbedtls_x509_crt_free(cacert);
git__free(cacert);
mbedtls_strerror( ret, errbuf, 512 );
giterr_set(GITERR_SSL, "failed to load CA certificates : %s (%d)", errbuf, ret);
giterr_set(GITERR_SSL, "failed to load CA certificates: %#04x - %s", ret, errbuf);
return -1;
}

Expand Down