online::clone: skip creds fallback test #4584
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't love resorting to this, but I was hoping that this was just a temporary problem for bitbucket (it seems like it only affects some requests). I opened #4585 to ensure that we didn't forget about this. |
pks-t
reviewed
Mar 19, 2018
tests/online/clone.c
Outdated
| g_options.fetch_opts.callbacks.credentials = git_cred_userpass; | ||
| g_options.fetch_opts.callbacks.payload = &user_pass; | ||
|
|
||
| cl_skip(); |
There was a problem hiding this comment.
Could you please add a comment stating why this test is skipped? It's easy enough to dig it up via git blame, but I think it's good to have anyway
|
The fix is not ideal, but I guess we cannot do any better without known breakages from #4500, which I definitely don't want to merge for v0.27.0. So I agree with your solution here |
At present, we have three online tests against bitbucket: one which specifies the credentials in the payload, one which specifies the correct credentials in the URL and a final one that specifies the incorrect credentials in the URL. Bitbucket has begun responding to the latter test with a 403, which causes us to fail. Break these three tests into separate tests so that we can skip the latter until this is resolved on Bitbucket's end or until we can change the test to a different provider.
3363613 to
03c5877
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At present, we have three online tests against bitbucket: one which
specifies the credentials in the payload, one which specifies the
correct credentials in the URL and a final one that specifies the
incorrect credentials in the URL. Bitbucket has begun responding to the
latter test with a 403, which causes us to fail.
Break these three tests into separate tests so that we can skip the
latter until this is resolved on Bitbucket's end or until we can change
the test to a different provider.