Fix assorted leaks found via fuzzing #4698
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git__free is insufficient if the packet is a git_pkt_ref or another type that requires freeing referenced structures.
pks-t
reviewed
Jun 25, 2018
src/transports/smart_protocol.c
Outdated
|
|
||
| while (1) { | ||
| git__free(pkt); | ||
| if (pkt) { |
There was a problem hiding this comment.
We usually do not check whether a pointer is set before freeing it. But in this case it is necessary, as git_pkt_free doesn't check for NULL pointers itself
src/transports/smart_protocol.c
Outdated
| @@ -622,7 +622,9 @@ int git_smart__download_pack( | |||
| } | |||
| } | |||
|
|
|||
| git__free(pkt); | |||
| if (pkt) { | |||
| git_pkt_free(pkt); | |||
There was a problem hiding this comment.
Huh, one more time. I know it's not your fault, but instead the existing code is to blame. But I'd highly appreciate if you did a preliminary commit which fixes git_pkt_free to return early in case a NULL pointer is being passed to it.
|
By the way, did you already see #4433? |
|
I hadn't! Thanks for the pointer, I'll look into that past attempt. |
|
Fixed |
|
Thanks for this. 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were all found by my work-in-progress oss-fuzz fuzzer.