threads::diff: use separate git_repository objects #4754
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our thread policies state that we cannot re-use the `git_repository` across threads. Our tests cannot deviate from that.
|
Fixes #4753 |
|
I considered simply deleting these tests - it feels rather obvious that this should always succeed now that we're using multiple repository objects. But after more consideration, this does exercise the object cache, etc, and it seems reasonable to keep it. |
|
Does it really? I thought the object cache was per repository. |
|
This improves the situation but doesn't get rid of the segfault completely, I posted another stack trace in #4753. |
|
The object caches are per-repository but the packfiles and their caches are shared. I don't see how we would fail on ignore rules unless we're grabbing from a global cache of built-in rules or mismanaging the lifetime of these objects. |
Our thread policies state that we cannot re-use the `git_repository` across threads. Our tests cannot deviate from that. Courtesy of Ximin Luo, https://github.com/infinity0: #4753 (comment)
|
Thanks, @infinity0, I've added your change from #4753. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our thread policies state that we cannot re-use the
git_repositoryacross threads. Our tests cannot deviate from that.