Thanks to visit codestin.com
Credit goes to github.com

Skip to content

xdiff: fix typo #5024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 29, 2019
Merged

xdiff: fix typo #5024

merged 1 commit into from
Mar 29, 2019

Conversation

stewid
Copy link
Contributor

@stewid stewid commented Mar 20, 2019

Fixes a typo that was introduced in f347a44

I found this when the R bindings git2r (bundles libgit2) failed to build on Solaris using Oracle Developer Studio 12.6.

pks-t
pks-t approved these changes Mar 29, 2019
View reviewed changes
Copy link
Member

@pks-t pks-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, that's my fault and has been introduced in commit f347a44 (treewide: avoid use of inline attribute, 2018-06-25). The fix is obviously correct.

@pks-t pks-t merged commit 5f188c4 into libgit2:master Mar 29, 2019
@pks-t
Copy link
Member

pks-t commented Mar 29, 2019

Thanks for fixing my stuff!

@stewid
Copy link
Contributor Author

stewid commented Mar 29, 2019

Thanks

@snyk-bot snyk-bot mentioned this pull request Feb 23, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Apr 22, 2020
Open
@snyk-bot snyk-bot mentioned this pull request May 5, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pks-t pks-t pks-t approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stewid @pks-t