-
Notifications
You must be signed in to change notification settings - Fork 2.5k
rebase: orig_head and onto accessors #5057
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The rebase struct stores fields with information about the current rebase process, which were not accessible via a public interface. Accessors for getting the `orig_head` and `onto` branch names and object ids have been added.
Since you're poking around interactive rebase, this is my own poke around the rebase code. Started last year, quickly rebased, may contain hazardous material, YMMV. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the accessor comment, this looks fine to me. Thanks @eaigner 👍 !
I reverted it to the original approach, since annotated commits seem overkill to me and I think its better to reflect the actual files on disk without having some voodoo magic inbetween. I left the string accessors with So the interface looks like this again:
|
LGTM. Thanks @eaigner! |
🎉😊 |
The rebase struct stores fields with information about the current
rebase process, which were not accessible via a public interface.
Accessors for getting the
orig_head
andonto
branchnames and object ids have been added.