Support symlinks for directories in win32 #5065
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
/rebuild |
|
Okay, @ethomson, I started to rebuild this pull request as build #1896. |
|
Thanks for the fix @danielgindi! |
ethomson
approved these changes
May 12, 2019
|
And yes @pks-t I'm in favor of backporting this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #4713 had one thing missing, which is correctly setting the
SYMBOLIC_LINK_FLAG_DIRECTORYfor directories, as Windows weirdly handles symlinks differently than unix-like systems.This issue is discussed with @ethomson in #4713.