deps: ntlmclient: disable implicit fallthrough warnings #5112
Conversation
The ntlmclient dependency has quite a lot of places with implicit fallthroughs. As at least modern GCC has enabled warnings on implicit fallthroughs by default, the developer is greeted with a wall of warnings when compiling that dependency. Disable implicit fallthrough warnings for ntlmclient to fix this issue.
|
LGTM (nightlies-only bionic builds failed because of that). Though I see Hopefully this is just a confused GCC ? |
Yeah, I don't really know where that comes from, but we had that issue since several months already. I've noticed it multiple times, but I've got no idea when exactly it pops up and I didn't think it important enough to really care |
|
I'm happy enough to fix this in ntmlclient itself, if you'd prefer. My goal in building ntlmclient was for it to basically be part of libgit2 (in terms of codestyle, etc) but available for others as well. 🤷♂ |
|
@ethomson: how about merging this as a short-term fix with the mid-term goal being to fix it in ntlmclient? |
|
Welp, I tried going through |
The ntlmclient dependency has quite a lot of places with implicit
fallthroughs. As at least modern GCC has enabled warnings on
implicit fallthroughs by default, the developer is greeted with a
wall of warnings when compiling that dependency.
Disable implicit fallthrough warnings for ntlmclient to fix this
issue.