Add compat typdef for git_attr_t #5310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some libraries haven't updated to git_attr_value_t and break. Adding the comapt typedef as suggested.
9ffaa0b to
aea049b
Compare
|
Oops. Makes sense. Thanks for the fix. Instead of starting a new attribute section, can you put this in the attribute section right above? |
|
@ethomson done! |
|
Perfect. Thanks! And apologies for the oversight. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some libraries haven't updated to git_attr_value_t and break. Adding
the comapt typedef as suggested.
@pks-t please let me know if there's anything else needed. I took a brief look but didn't see an obvious place where to add tests. If required please let me know.