Return int from non-free functions #5365
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siprbaum
reviewed
Jan 19, 2020
ff1a1fb to
c1ce497
Compare
pks-t
approved these changes
Jan 24, 2020
| git_index_name_clear(index); | ||
| if ((error = git_index_name_clear(index)) < 0 || | ||
| (error = git_index_reuc_clear(index)) < 0) | ||
| goto done; |
| git_index_reuc_clear(index); | ||
| if ((error = git_index_name_clear(index)) < 0 || | ||
| (error = git_index_reuc_clear(index)) < 0) | ||
| goto done; |
Stop returning a void for functions, future-proofing them to allow them to fail.
Stop returning a void for functions, future-proofing them to allow them to fail.
Stop returning a void for functions, future-proofing them to allow them to fail.
Stop returning a void for functions, future-proofing them to allow them to fail.
Stop returning a void for functions, future-proofing them to allow them to fail.
Stop returning a void for functions, future-proofing them to allow them to fail.
Stop returning a void for functions, future-proofing them to allow them to fail.
Stop returning a void for functions, future-proofing them to allow them to fail.
Stop returning a void for functions, future-proofing them to allow them to fail.
Stop returning a void for functions, future-proofing them to allow them to fail.
c1ce497 to
4cae9e7
Compare
|
Fixed! Thanks for the review @pks-t |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return
intfrom all the functions that aren'tdisposeorfreefunctions. This allows us to gracefully fail on bad inputs (instead of anassertor crashing with a segmentation fault).Only functions that cannot fail will remain void. This includes:
*_disposeand*_free: which should gracefully takeNULLpointers, ignore them, and continue.giterr_clear: which cannot fail (since it just updates pointers in global state)giterr_set_oom: which cannot fail (since it just updates pointers in global state)