Fix a string concatenation bug when validating extensions #6246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation
As builtin extensions are evaluated in the latter half of `check_valid_extension`, a string `cfg` is concatenated with the static string 'extension.' and the value from `builtin_extension`, before being compared with the configured value. This string is not being cleared while iterating through the names of the extensions. Because there is currently only one extension ('noop'), the bug was never noticible.
This patch corrects the behavior by clearing the string on each iteration, as is done in the first block.
|
I noticed this while testing the following patch: https://github.com/vermiculus/libgit2/tree/sallred/support-worktree-config |
This was referenced Mar 16, 2022
|
Oops, good catch. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As builtin extensions are evaluated in the latter half of
check_valid_extension, a stringcfgis concatenated with the static string 'extension.' and the value frombuiltin_extension, before being compared with the configured value. This string is not being cleared while iterating through the names of the extensions. Because there is currently only one extension (noop), the bug was never noticeable.This patch corrects the behavior by clearing the string on each iteration, as is done in for user extensions in the preceding block.