Add HTTPS support #697
Merged
Add HTTPS support #697
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| gnutls_certificate_free_credentials(t->ssl.cred); | ||
| gnutls_global_deinit(); | ||
| #elif defined(GIT_OPENSS) | ||
| int ret; |
|
|
||
| /* If it contains embedded NULs, don't even try */ | ||
| if (namelen != strnlen(name, namelen)) { | ||
| puts("bad length"); |
If it's not available, an error saying so will be returned when trying to use a https:// URL. This also unifies a lot of the network code to use git_transport in many places instead of an socket descriptor.
Add specific functions that use OpenSSL instead of GnuTLS
This should help us free some resources, though the libraries do keep some buffers allocated regardless.
It's too much work for now to redo everything. Move the ssl context struct to transport.h
Sometimes it's useful not to perform the check. Allow it to be configurable.
|
✨ Let's get started on WinHTTP. |
phatblat
pushed a commit
to phatblat/libgit2
that referenced
this pull request
Sep 13, 2014
Add HTTPS support
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support connecting to https:// URLs