Add support for user TLS authentication #7016 #7035
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows for the use case where a user is providing an openssl key and certificate as their authentication to an HTTPS server. New option GIT_OPT_SET_SSL_USER_KEY to set paths for user private key and certificate files. New option GIT_OPT_SET_SSL_PASSWORD_CALLBACK provides a means for a callback function to prompt for password to unlock the key.
|
Thanks for the PR; I've been noodling on this a little bit, and I wonder if a library option is the best place for this. In particular, I wonder if it's really server / remote specific. Is there a situation where you would want to present two different certificates to two different remotes? Or - perhaps more likely - you would want to present user / client certificates to an internal server, but you would want to present no client certs to a public server (like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for the use case where a user is providing an openssl key and certificate as their authentication to an HTTPS server.
New option GIT_OPT_SET_SSL_USER_KEY to set paths for user private key and certificate files.
New option GIT_OPT_SET_SSL_PASSWORD_CALLBACK provides a means for a callback function to prompt for password to unlock the key.