Fixes cmake caching #7109
Open
Fixes cmake caching #7109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the CMake install step so that the placeholder experimental.h in the source tree isn’t copied over and then immediately overwritten by the generated header from the build directory.
- Excludes
experimental.hfrom the source include directory in theinstall(DIRECTORY ...)call. - Continues to install the generated
experimental.hfrom the build directory via a separateinstall(FILES ...)call.
Comments suppressed due to low confidence (1)
src/libgit2/CMakeLists.txt:137
- [nitpick] This line mixes tabs and spaces for indentation. Please follow the project’s standard indentation style (either spaces or tabs) to keep CMakeLists.txt consistent.
PATTERN "experimental.h" EXCLUDE)
| @@ -133,7 +133,8 @@ install(TARGETS libgit2package | |||
| LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR} | |||
| ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR}) | |||
| install(DIRECTORY ${PROJECT_SOURCE_DIR}/include/git2/ | |||
| DESTINATION "${CMAKE_INSTALL_INCLUDEDIR}/${LIBGIT2_FILENAME}") | |||
| DESTINATION "${CMAKE_INSTALL_INCLUDEDIR}/${LIBGIT2_FILENAME}" | |||
| PATTERN "experimental.h" EXCLUDE) | |||
There was a problem hiding this comment.
[nitpick] The closing parenthesis for the install(DIRECTORY ...) command has moved to the PATTERN line, making the DESTINATION line look unbalanced. Consider placing the closing parenthesis on its own line or aligning it consistently for readability.
Suggested change
| PATTERN "experimental.h" EXCLUDE) | |
| PATTERN "experimental.h" EXCLUDE | |
| ) |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes cmake caching by making sure that the placeholder file
${PROJECT_SOURCE_DIR}/include/git2/experimental.his not copied to the install directory. Otherwise, on the next step the file would otherwise be overwritten by the generated version${PROJECT_BINARY_DIR}/include/git2/experimental.h.Fixes the issue #7110