Fixed a heap-buffer-overflow in the smart_pkt.c:set_data function. #7118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The strstr call used to find the " object-format=" capability string did not have a length limit, potentially reading past the end of the allocated buffer if the capabilities string was not null-terminated within the buffer bounds. Replaced strstr with git__memmem and subsequent strchr calls with memchr, providing the remaining buffer length as a limit to prevent out-of-bounds reads. https: //oss-fuzz.com/testcase-detail/4895812384325632 https: //issues.oss-fuzz.com/issues/42524461 Change-Id: Id313af1bce48ea8763fa2dfd7eb9ee8934fa541f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The strstr call used to find the " object-format=" capability string did not have a length limit, potentially reading past the end of the allocated buffer if the capabilities string was not null-terminated within the buffer bounds. Replaced strstr with git__memmem and subsequent strchr calls with memchr, providing the remaining buffer length as a limit to prevent out-of-bounds reads.
https://oss-fuzz.com/testcase-detail/4895812384325632
https://issues.oss-fuzz.com/issues/42524461