Thanks to visit codestin.com
Credit goes to github.com

Skip to content

ci: Fix cases of -Werror=discarded-qualifiers raised by gcc 15.2 #7164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ethomson merged 1 commit into from
Dec 20, 2025
Merged

ci: Fix cases of -Werror=discarded-qualifiers raised by gcc 15.2 #7164

ethomson merged 1 commit into from
Dec 20, 2025

Conversation

@ambv
Copy link
Contributor

@ambv ambv commented Dec 6, 2025

With yesterday's update to the Fedora rawhide Docker image, the new gcc 15.2 started reporting some discarded qualifier warnings, that we treat as errors:

/home/libgit2/source/src/libgit2/attr_file.c: In function 'git_attr_fnmatch__parse':
/home/libgit2/source/src/libgit2/attr_file.c:814:31: error: initialization discards 'const' qualifier from pointer target type [-Werror=discarded-qualifiers]
  814 |                 char *slash = strrchr(context, '/');
      |                               ^~~~~~~
At top level:
cc1: all warnings being treated as errors

This PR fixes all of them so the build passes in Docker.

ambv
ambv commented Dec 6, 2025
View reviewed changes
tests/libgit2/refs/reflog/reflog.c
cl_git_pass(git_str_join_n(&logpath, '/', 3, git_repository_path(g_repo), GIT_REFLOG_DIR, refname));
cl_git_pass(git_futils_readbuffer(&logcontents, git_str_cstr(&logpath)));
cl_assert((star = strchr(git_str_cstr(&logcontents), '*')) != NULL);
cl_assert((star = strchr(logcontents.ptr, '*')) != NULL);
Copy link
Contributor Author

@ambv ambv Dec 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of the other cases are trivial, this one's a bit different. It's because we are indeed writing through star in the next line to modify the buffer, so I just used .ptr directly.

@ethomson ethomson merged commit cd3ebc9 into libgit2:main Dec 20, 2025
19 checks passed
@ethomson
Copy link
Member

ethomson commented Dec 20, 2025

Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ethomson ethomson ethomson approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ambv @ethomson