Fixes #1217 #1218
Closed
Fixes #1217 #1218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added CustomHeaders member to GitPushOptions to match underlying c struct for marshalling. Added tests suggested by @nulltoken to PushFixture.cs
|
Awesome!! @golsby Actually, even if that seems a bit strange, I'd be in favor of dropping the test. Those kind of tests cannot be relied on as we need to run them manually (because of creds one wouldn't see to be committed). Could you please rewrite your commit and remove the test from it? While you're at it, I'd really prefer if you could put what the commit does in the first line (as this is what is being shown when doing a Maybe something like this? |
The default prettifying behabiour now is: do not prettify Documentation for the new property of RewriteHistoryOptions
Added CustomHeaders member to GitPushOptions to match underlying c struct for marshalling. Added tests suggested by @nulltoken to PushFixture.cs
|
Tidied up and resubmitted in #1233 on behalf of @golsby. @nulltoken, please close this PR. |
|
Supersed by #1233. Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added CustomHeaders member to GitPushOptions to match underlying c struct for marshalling.
Added tests suggested by @nulltoken to PushFixture.cs